Apps: Use new folder style for Catfish #482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the icon upstream uses for `system-file-manager`. But elementary-xfce has always used folder-with-home-emblem for `system-file-manager` and folder-with-magnifying-glass-emblem for Catfish. So this just continues that style. Maybe in the future following upstream will make more sense, in which case maybe a new design for Catfish will be needed (or not providing a Catfish icon and defaulting to the app-provided icon).
newhoa
force-pushed
the
apps-catfish
branch
from
b2d300f to
39ecd25
Compare
|
I'm going to go ahead with this for now. It's at least more consistent. If there are objections to it in the future we can always change it back or come up with something better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the icon upstream uses for
system-file-manager.But elementary-xfce has always used folder-with-home-emblem for
system-file-managerand folder-with-magnifying-glass-emblem for Catfish. So this just continues that style.@ochosi, are you okay with this split (or should we follow upstream on this):
system-file-managerIf the split from upstream isn't okay, we might need to come up with either a new emblem for Catfish if we want to use the new folder style, or just a different non-folder based icon altogether. Or simply not provide one and use the app-provided icon (the catfish with monocle).