Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: argo status updater changes #168

Merged
merged 5 commits into from
Aug 15, 2023
Merged

chore: argo status updater changes #168

merged 5 commits into from
Aug 15, 2023

Conversation

bozerkins
Copy link
Collaborator

We talked about simplifying this class, since it's too bulky and non-trivial.

This PR is an attempt to make it more straight forward.

Notable changes:

  1. Instead of fetching application extra time, we now re-use last application object we fetched
  2. We don't do retries anymore in cases when application is not found
  3. Error messages are standardized, with application deployment status in logs and reasons

@bozerkins bozerkins marked this pull request as ready for review August 12, 2023 17:29
@bozerkins bozerkins requested a review from shini4i as a code owner August 12, 2023 17:29
@bozerkins bozerkins requested a review from rustamar August 12, 2023 17:29
@shini4i shini4i changed the title Argo status updater changes chore: argo status updater changes Aug 13, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@shini4i shini4i merged commit 424d418 into main Aug 15, 2023
@shini4i shini4i deleted the simplify_argo_status_updater branch August 15, 2023 07:08
@shini4i shini4i mentioned this pull request Aug 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shini4i shini4i shini4i approved these changes

@rustamar rustamar Awaiting requested review from rustamar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bozerkins @shini4i