Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(state): change migrations back to migration library #172

Merged
merged 7 commits into from
Aug 16, 2023

Conversation

bozerkins
Copy link
Collaborator

@bozerkins bozerkins commented Aug 16, 2023

Returned the migration library that we used in previous iterations.
Created a new migration that adjusts the table structure to match ORM model configurations.
In future releases we should migrate to a migration tool that supports gorm - Atlas

@bozerkins bozerkins changed the title change migrations back to migration library and manually adjust the t… fix(state): change migrations back to migration library Aug 16, 2023
@bozerkins bozerkins marked this pull request as ready for review August 16, 2023 03:37
@bozerkins bozerkins requested a review from shini4i as a code owner August 16, 2023 03:37
@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Merging #172 (f198c2d) into main (a71fd2c) will increase coverage by 0.06%.
The diff coverage is 55.55%.

@@            Coverage Diff             @@
##             main     #172      +/-   ##
==========================================
+ Coverage   49.47%   49.53%   +0.06%     
==========================================
  Files          15       15              
  Lines         946      971      +25     
==========================================
+ Hits          468      481      +13     
- Misses        427      435       +8     
- Partials       51       55       +4     
Files Changed Coverage Δ
cmd/argo-watcher/config/config.go 83.33% <ø> (ø)
cmd/argo-watcher/state/postgres_state.go 63.46% <52.00%> (-2.71%) ⬇️
cmd/argo-watcher/state/in_memory_state.go 87.83% <100.00%> (+0.33%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarcloud
Copy link

sonarcloud bot commented Aug 16, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@shini4i shini4i merged commit c4b3c99 into main Aug 16, 2023
@shini4i shini4i deleted the orm_migration_fixes branch August 16, 2023 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants