-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: keycloak integration and redeploy button #230
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #230 +/- ##
=======================================
Coverage 53.34% 53.34%
=======================================
Files 18 18
Lines 1331 1331
=======================================
Hits 710 710
Misses 556 556
Partials 65 65 ☔ View full report in Codecov by Sentry. |
Although these changes do not break the backward compatibility, they are still pretty big. I would appreciate it if you guys could take a look. @bozerkins @rustamar @tomsozolins |
Quality Gate passedThe SonarCloud Quality Gate passed, but some issues were introduced. 2 New issues |
This pull request incorporates the following changes:
OPEN IN ARGOCD UI
button to simplify troubleshootingROLLBACK TO THIS VERSION
button to the page with task details visible only if the user is authenticated and a member of the provided privileged group.There are still some open questions about the logic behind this button, as we need to provide a token to the backend, usually supplied by the client. The user should not have it. We can't really reuse the token from Keycloak as the backend has no connection with it.
Currently, I've implemented the most straightforward approach. We ask the user to provide the token manually.
When merged, it will close #175