Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: keycloak integration and redeploy button #230

Merged
merged 14 commits into from
Dec 22, 2023
Merged

Conversation

shini4i
Copy link
Owner

@shini4i shini4i commented Dec 13, 2023

This pull request incorporates the following changes:

  • Adds a basic integration with Keycloak to the frontend (optional)
  • Adds the OPEN IN ARGOCD UI button to simplify troubleshooting
  • Adds the ROLLBACK TO THIS VERSION button to the page with task details visible only if the user is authenticated and a member of the provided privileged group.
  • Hides "Status Details" on Deployed tasks as there is no reason to show an empty field

There are still some open questions about the logic behind this button, as we need to provide a token to the backend, usually supplied by the client. The user should not have it. We can't really reuse the token from Keycloak as the backend has no connection with it.

Currently, I've implemented the most straightforward approach. We ask the user to provide the token manually.

When merged, it will close #175

Screenshot 2023-12-14 at 17 06 49

@shini4i shini4i self-assigned this Dec 13, 2023
Copy link

codecov bot commented Dec 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (88d70bd) 53.34% compared to head (5149d84) 53.34%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #230   +/-   ##
=======================================
  Coverage   53.34%   53.34%           
=======================================
  Files          18       18           
  Lines        1331     1331           
=======================================
  Hits          710      710           
  Misses        556      556           
  Partials       65       65           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shini4i
Copy link
Owner Author

shini4i commented Dec 15, 2023

As a simple scenario, the following approach seems to be the easiest at the moment:

Screenshot 2023-12-15 at 15 03 15

@shini4i shini4i marked this pull request as ready for review December 15, 2023 13:06
@shini4i shini4i requested a review from bozerkins as a code owner December 15, 2023 13:06
@shini4i
Copy link
Owner Author

shini4i commented Dec 15, 2023

Although these changes do not break the backward compatibility, they are still pretty big. I would appreciate it if you guys could take a look. @bozerkins @rustamar @tomsozolins

Copy link

sonarcloud bot commented Dec 21, 2023

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

2 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@shini4i shini4i merged commit e18a23c into main Dec 22, 2023
4 checks passed
@shini4i shini4i deleted the chore/keycloak-frontend branch December 22, 2023 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add redeploy button to ui
1 participant