Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for sending webhook events #271

Merged
merged 11 commits into from
Mar 31, 2024
Merged

Conversation

shini4i
Copy link
Owner

@shini4i shini4i commented Mar 30, 2024

Closes #256, potentially can partly cover #131

Copy link

codecov bot commented Mar 30, 2024

Codecov Report

Attention: Patch coverage is 57.14286% with 24 lines in your changes are missing coverage. Please review.

Project coverage is 51.23%. Comparing base (87b56d7) to head (05b0bc4).

Files Patch % Lines
cmd/argo-watcher/notifications/webhook.go 60.52% 10 Missing and 5 partials ⚠️
cmd/argo-watcher/argocd/argo_status_updater.go 52.94% 5 Missing and 3 partials ⚠️
cmd/argo-watcher/server/server.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #271      +/-   ##
==========================================
+ Coverage   50.99%   51.23%   +0.23%     
==========================================
  Files          25       26       +1     
  Lines        1653     1702      +49     
==========================================
+ Hits          843      872      +29     
- Misses        737      751      +14     
- Partials       73       79       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@shini4i shini4i marked this pull request as ready for review March 31, 2024 19:11
@shini4i shini4i merged commit 601b58f into main Mar 31, 2024
4 checks passed
@shini4i shini4i deleted the feat/notifications branch March 31, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add support for sending webhook events
1 participant