Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: code cleanup #284

Merged
merged 8 commits into from
May 1, 2024
Merged

chore: code cleanup #284

merged 8 commits into from
May 1, 2024

Conversation

shini4i
Copy link
Owner

@shini4i shini4i commented Apr 30, 2024

This PR incorporates the following changes:

  • Removed unused logging setup
  • Replaced text status with icons in frontend to prettify the table page
  • Dealt with broken "app not found" logic that was caused by changes introduced in argocd 2.6.7
  • Bump versions of backend dependencies
  • Small code cleanup here and there

Copy link

codecov bot commented Apr 30, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 53.41%. Comparing base (cbdd6a5) to head (2ebb33a).

Files Patch % Lines
cmd/argo-watcher/server/server.go 50.00% 1 Missing ⚠️
cmd/argo-watcher/state/postgres_state.go 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #284      +/-   ##
==========================================
- Coverage   53.42%   53.41%   -0.02%     
==========================================
  Files          26       26              
  Lines        1840     1831       -9     
==========================================
- Hits          983      978       -5     
+ Misses        766      762       -4     
  Partials       91       91              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented May 1, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@shini4i shini4i marked this pull request as ready for review May 1, 2024 10:33
@shini4i shini4i merged commit 2ee50a0 into main May 1, 2024
4 of 5 checks passed
@shini4i shini4i deleted the chore/code-cleanup branch May 1, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant