Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(client): add support for additional configuration #306

Merged
merged 2 commits into from
May 25, 2024

Conversation

shini4i
Copy link
Owner

@shini4i shini4i commented May 25, 2024

These changes support specifying retry interval and expected deployment time to provide feedback about a potential deployment issue sooner.

After the threshold is met, the client will start logging additional information about the necessity of checking the setup in ArgoCD UI.

Copy link

codecov bot commented May 25, 2024

Codecov Report

Attention: Patch coverage is 53.33333% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 56.19%. Comparing base (d833f36) to head (a000a94).

Files Patch % Lines
pkg/client/client.go 36.36% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #306      +/-   ##
==========================================
- Coverage   56.25%   56.19%   -0.06%     
==========================================
  Files          27       27              
  Lines        1838     1847       +9     
==========================================
+ Hits         1034     1038       +4     
- Misses        712      717       +5     
  Partials       92       92              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented May 25, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@shini4i shini4i marked this pull request as ready for review May 25, 2024 22:03
@shini4i shini4i merged commit 6119c19 into main May 25, 2024
6 of 8 checks passed
@shini4i shini4i deleted the chore/extend-client-configuration branch May 25, 2024 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant