Merge pull request #293 from poppingmoon/dispose-text-editing-controller

TextEditingControllerをdisposeする
shiosyakeyakini-info · Sep 9, 2023 · aa39a8a · aa39a8a
2 parents 3835a71 + 7726c7f
commit aa39a8a
Show file tree

Hide file tree

Showing 14 changed files with 87 additions and 3 deletions.
diff --git a/lib/state_notifier/photo_edit_page/image_meta_dialog.dart b/lib/state_notifier/photo_edit_page/image_meta_dialog.dart
@@ -29,6 +29,13 @@ class ImageMetaDialogState extends ConsumerState<ImageMetaDialog> {
   late final TextEditingController captionController = TextEditingController()
     ..text = widget.initialMeta.caption;
 
+  @override
+  void dispose() {
+    fileNameController.dispose();
+    captionController.dispose();
+    super.dispose();
+  }
+
   @override
   Widget build(BuildContext context) {
     return AlertDialog(

diff --git a/lib/view/dialogs/note_detail_dialog.dart b/lib/view/dialogs/note_detail_dialog.dart
@@ -52,6 +52,12 @@ class NoteDetailDialogState extends ConsumerState<NoteDetailDialog> {
     });
   }
 
+  @override
+  void dispose() {
+    reactionTextField.dispose();
+    super.dispose();
+  }
+
   @override
   Widget build(BuildContext context) {
     return AlertDialog(

diff --git a/lib/view/login_page/api_key_login.dart b/lib/view/login_page/api_key_login.dart
@@ -19,6 +19,13 @@ class APiKeyLoginState extends ConsumerState<ApiKeyLogin> {
   final serverController = TextEditingController();
   final apiKeyController = TextEditingController();
 
+  @override
+  void dispose() {
+    serverController.dispose();
+    apiKeyController.dispose();
+    super.dispose();
+  }
+
   Future<void> login() async {
     try {
       IndicatorView.showIndicator(context);

diff --git a/lib/view/login_page/mi_auth_login.dart b/lib/view/login_page/mi_auth_login.dart
@@ -19,6 +19,12 @@ class MiAuthLoginState extends ConsumerState<MiAuthLogin> {
   final serverController = TextEditingController();
   bool isAuthed = false;
 
+  @override
+  void dispose() {
+    serverController.dispose();
+    super.dispose();
+  }
+
   Future<void> login() async {
     try {
       IndicatorView.showIndicator(context);

diff --git a/lib/view/login_page/password_login.dart b/lib/view/login_page/password_login.dart
@@ -17,6 +17,14 @@ class PasswordLoginState extends ConsumerState<PasswordLogin> {
   final userController = TextEditingController();
   final passwordController = TextEditingController();
 
+  @override
+  void dispose() {
+    serverController.dispose();
+    userController.dispose();
+    passwordController.dispose();
+    super.dispose();
+  }
+
   Future<void> login() async {
     await ref.read(accountRepository).loginAsPassword(
         serverController.text, userController.text, passwordController.text);

diff --git a/lib/view/note_create_page/cw_text_area.dart b/lib/view/note_create_page/cw_text_area.dart
@@ -25,6 +25,12 @@ class CwTextAreaState extends ConsumerState<CwTextArea> {
     });
   }
 
+  @override
+  void dispose() {
+    cwController.dispose();
+    super.dispose();
+  }
+
   @override
   Widget build(BuildContext context) {
     ref.listen(

diff --git a/lib/view/note_create_page/file_settings_dialog.dart b/lib/view/note_create_page/file_settings_dialog.dart
@@ -35,6 +35,12 @@ class FileSettingsDialogState extends ConsumerState<FileSettingsDialog> {
     isNsfw = widget.file.isNsfw;
   }
 
+  @override
+  void dispose() {
+    captionController.dispose();
+    super.dispose();
+  }
+
   String generateRandomText() {
     var str = "abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789"
         .split("");

diff --git a/lib/view/note_create_page/vote_area.dart b/lib/view/note_create_page/vote_area.dart
@@ -112,6 +112,12 @@ class VoteContentListItemState extends ConsumerState<VoteContentListItem> {
     });
   }
 
+  @override
+  void dispose() {
+    controller.dispose();
+    super.dispose();
+  }
+
   @override
   Widget build(BuildContext context) {
     return Padding(

diff --git a/lib/view/search_page/note_search.dart b/lib/view/search_page/note_search.dart
@@ -36,6 +36,12 @@ class NoteSearchState extends ConsumerState<NoteSearch> {
     }
   }
 
+  @override
+  void dispose() {
+    controller.dispose();
+    super.dispose();
+  }
+
   @override
   Widget build(BuildContext context) {
     final selectedUser = ref.watch(noteSearchUserProvider);

diff --git a/lib/view/settings_page/tab_settings_page/tab_settings_page.dart b/lib/view/settings_page/tab_settings_page/tab_settings_page.dart
@@ -85,6 +85,12 @@ class TabSettingsAddDialogState extends ConsumerState<TabSettingsPage> {
     }
   }
 
+  @override
+  void dispose() {
+    nameController.dispose();
+    super.dispose();
+  }
+
   @override
   Widget build(BuildContext context) {
     return Scaffold(

diff --git a/lib/view/several_account_settings_page/hard_mute_page/hard_mute_page.dart b/lib/view/several_account_settings_page/hard_mute_page/hard_mute_page.dart
@@ -20,6 +20,12 @@ class HardMutePage extends ConsumerStatefulWidget {
 class HardMutePageState extends ConsumerState<HardMutePage> {
   final controller = TextEditingController();
 
+  @override
+  void dispose() {
+    controller.dispose();
+    super.dispose();
+  }
+
   String muteValueString(List<MuteWord>? wordMutes) {
     if (wordMutes == null) return "";
 

diff --git a/lib/view/time_line_page/timeline_note.dart b/lib/view/time_line_page/timeline_note.dart
@@ -2,7 +2,9 @@ import 'package:flutter/material.dart';
 import 'package:miria/view/themes/app_theme.dart';
 import 'package:flutter_riverpod/flutter_riverpod.dart';
 
-final timelineNoteProvider = Provider((ref) => TextEditingController());
+final timelineNoteProvider =
+    ChangeNotifierProvider.autoDispose((ref) => TextEditingController());
+
 final timelineFocusNode =
     ChangeNotifierProvider.autoDispose((ref) => FocusNode());
 
@@ -26,10 +28,10 @@ class TimelineNoteFieldState extends ConsumerState<TimelineNoteField> {
     return Padding(
       padding: const EdgeInsets.only(left: 8.0, right: 8.0),
       child: TextField(
-        focusNode: ref.read(timelineFocusNode),
+        focusNode: ref.watch(timelineFocusNode),
         keyboardType: TextInputType.multiline,
         maxLines: null,
-        controller: ref.read(timelineNoteProvider),
+        controller: ref.watch(timelineNoteProvider),
         decoration: noteStyle,
       ),
     );

diff --git a/lib/view/user_page/update_memo_dialog.dart b/lib/view/user_page/update_memo_dialog.dart
@@ -38,6 +38,12 @@ class UpdateMemoDialogState extends ConsumerState<UpdateMemoDialog> {
     controller.text = widget.initialMemo;
   }
 
+  @override
+  void dispose() {
+    controller.dispose();
+    super.dispose();
+  }
+
   @override
   Widget build(BuildContext context) {
     return AlertDialog(

diff --git a/lib/view/user_select_dialog.dart b/lib/view/user_select_dialog.dart
@@ -45,6 +45,12 @@ final usersSelectDialogOriginProvider =
 class UserSelectContentState extends ConsumerState<UserSelectContent> {
   final queryController = TextEditingController();
 
+  @override
+  void dispose() {
+    queryController.dispose();
+    super.dispose();
+  }
+
   @override
   Widget build(BuildContext context) {
     final origin = ref.watch(usersSelectDialogOriginProvider);