Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

設定のインポート・エクスポートのダイアログ修正 #208

Conversation

poppingmoon
Copy link
Contributor

@poppingmoon poppingmoon commented Jul 28, 2023

  • ダイアログが閉じられないのを修正しました
    • popのときに FolderResult を返すようにして、それ自体がnullのときと中身がnullのときで処理を変えるようにしました
  • インポートのダイアログの文言が間違っているのを修正しました
  • フォルダとフォルダーはMisskey本体でも表記ゆれしていたのですが、比較的多く使われていたフォルダーの方に統一しました

Fix #178
Fix #179

@shiosyakeyakini-info shiosyakeyakini-info changed the base branch from master to develop August 21, 2023 21:14
@poppingmoon poppingmoon force-pushed the fix-import-export-dialog branch from 4379c16 to 1c59dce Compare September 2, 2023 06:12
@codecov-commenter
Copy link

codecov-commenter commented Sep 2, 2023

Codecov Report

Merging #208 (917336b) into develop (239feeb) will increase coverage by 0.00%.
The diff coverage is 0.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@           Coverage Diff            @@
##           develop     #208   +/-   ##
========================================
  Coverage    23.80%   23.80%           
========================================
  Files          206      206           
  Lines         9831     9829    -2     
========================================
  Hits          2340     2340           
+ Misses        7491     7489    -2     
Files Coverage Δ
lib/repository/import_export_repository.dart 0.00% <0.00%> (ø)
..._page/import_export_page/folder_select_dialog.dart 0.00% <0.00%> (ø)
...gs_page/import_export_page/import_export_page.dart 2.04% <0.00%> (+0.08%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@poppingmoon poppingmoon force-pushed the fix-import-export-dialog branch from 1c59dce to c857ca9 Compare September 18, 2023 16:51
@poppingmoon poppingmoon force-pushed the fix-import-export-dialog branch from c857ca9 to 917336b Compare September 26, 2023 10:02
@poppingmoon poppingmoon force-pushed the fix-import-export-dialog branch from 917336b to 8452999 Compare September 27, 2023 22:32
@shiosyakeyakini-info shiosyakeyakini-info merged commit 53d7e5a into shiosyakeyakini-info:develop Oct 1, 2023
1 check passed
@shiosyakeyakini-info
Copy link
Owner

マージしました!ありがとうございます

@poppingmoon poppingmoon deleted the fix-import-export-dialog branch October 2, 2023 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants