PushableListViewの読み込み件数が0のときアイコンを表示しない #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #280 +/- ##
===========================================
+ Coverage 38.52% 38.55% +0.02%
===========================================
Files 248 248
Lines 12113 12116 +3
===========================================
+ Hits 4667 4671 +4
+ Misses 7446 7445 -1 ☔ View full report in Codecov by Sentry. |
poppingmoon
force-pushed
the
fix-pushable-listview
branch
from
ccbdc5e to
8e39496
Compare
poppingmoon
force-pushed
the
fix-pushable-listview
branch
from
084b701 to
07c3e16
Compare
poppingmoon
force-pushed
the
fix-pushable-listview
branch
from
07c3e16 to
6f5bad1
Compare
poppingmoon
force-pushed
the
fix-pushable-listview
branch
from
6f5bad1 to
f3e3f63
Compare
poppingmoon
force-pushed
the
fix-pushable-listview
branch
from
f3e3f63 to
c3a678f
Compare
poppingmoon
force-pushed
the
fix-pushable-listview
branch
from
c3a678f to
117c934
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PushableListViewのinitializeFutureの結果が空のときに「ありません」と表示するようにしました
変更前は、公開クリップのないユーザーのクリップ一覧やリプライのないノートの詳細画面などに反応しない下向き矢印が表示されていました
この変更によって、結果が空のとき、次の画面以外のPushableListViewでは「ありません」と表示するようになります