省略されたノートを一定の行まで表示する #295
Open
省略されたノートを一定の行まで表示する #295
+43
−55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ボタンの位置がずれていることがある |
TextOverflowをfadeから変更すると起こらなくなった |
poppingmoon
force-pushed
the
note-max-lines
branch
4 times, most recently
from
e6253dc to
af39efc
Compare
poppingmoon
force-pushed
the
note-max-lines
branch
from
af39efc to
0caecc1
Compare
|
mfm_rendererのほうはマージしました！
|
poppingmoon
force-pushed
the
note-max-lines
branch
from
0caecc1 to
9b2b223
Compare
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #295 +/- ##
===========================================
- Coverage 37.56% 37.51% -0.06%
===========================================
Files 251 251
Lines 13282 13263 -19
===========================================
- Hits 4990 4976 -14
+ Misses 8292 8287 -5 ☔ View full report in Codecov by Sentry. |
|
長いノートを折りたたむ設定でカスタム絵文字がボタンに重なるようなノートを表示したところ、ボタンを押すことができることを確認しました ノート (misskey.io) スクリーンショット
これを再現する際は改行コードがLFになっていることを確認してください positionやscaleに関係して不具合が起きそうなところが他にありそうなら教えてください |
poppingmoon
force-pushed
the
note-max-lines
branch
from
9b2b223 to
c3b79ec
Compare
poppingmoon
force-pushed
the
note-max-lines
branch
from
c3b79ec to
591036c
Compare
poppingmoon
force-pushed
the
note-max-lines
branch
from
591036c to
d42bb59
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
省略されたノートの表示にSimpleMfmTextの代わりにMfmTextを使い、リアクションをしたノートは1行、長いノートと判定されたノートは10行まで表示するようにしました
shiosyakeyakini-info/mfm_renderer#1 に依存します