Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

リモートのユーザーページをブラウザで開くときにuriではなくurlを優先する #654

Conversation

Npepperlinux
Copy link
Contributor

リモートのユーザーページをブラウザで開くときにuriではなくurlを優先するようにしました

(PRの背景:Threadsの返すurihttps://threads.net/ap/users/xxxxxxであり、このuriをブラウザで開くと{"success":false,"error":"Not found"}のみが表示されるため。ブラウザで開くにはhttps://threads.net/@userIdの形式であるurlを選択する必要がある)

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 27.69%. Comparing base (6955662) to head (b4bbb82).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
lib/view/user_page/user_control_dialog.dart 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #654   +/-   ##
========================================
  Coverage    27.69%   27.69%           
========================================
  Files          312      312           
  Lines        16253    16253           
========================================
  Hits          4501     4501           
  Misses       11752    11752           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shiosyakeyakini-info shiosyakeyakini-info merged commit aaec0b9 into shiosyakeyakini-info:develop Nov 10, 2024
1 check passed
@shiosyakeyakini-info
Copy link
Owner

🙇🙇🙇
(uriとurlが別の値なことあるんだ…)

@Npepperlinux Npepperlinux deleted the fix/switch_uri_url_open branch December 10, 2024 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants