Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

チャンネルページでisArchivedを明確に表示するように #671

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

Npepperlinux
Copy link
Contributor

@Npepperlinux Npepperlinux commented Nov 10, 2024

  • チャンネルがアーカイブされている場合に、「このチャンネルはアーカイブされています」と表示されるようにしました。また、ノートボタンが表示されなくなりました(Thanks @4ster1sk !)
    Screenshot from 2024-11-10 13-12-43

@codecov-commenter
Copy link

codecov-commenter commented Nov 10, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 40.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 27.61%. Comparing base (cb8696b) to head (3ed72b4).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
lib/view/channels_page/channel_detail_page.dart 25.00% 6 Missing ⚠️
lib/view/channels_page/channel_detail_info.dart 57.14% 3 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #671      +/-   ##
===========================================
+ Coverage    27.59%   27.61%   +0.01%     
===========================================
  Files          312      312              
  Lines        16454    16461       +7     
===========================================
+ Hits          4541     4545       +4     
- Misses       11913    11916       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@4ster1sk
Copy link
Contributor

書き込みボタン非表示はChannelDetailFloatingActionButtonAsyncData(:final value)ComminityChannelとれるのでそのへんでいい感じにすれば良さそう

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants