Allow passing cache: false to disable cache in getter

shioyama · Apr 6, 2017 · b4858ac · b4858ac
1 parent 4fd73d8
commit b4858ac
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/lib/mobility/backend/cache.rb b/lib/mobility/backend/cache.rb
@@ -35,7 +35,8 @@ module Backend
     module Cache
       # @group Backend Accessors
       # @!macro backend_reader
-      def read(locale, **_)
+      def read(locale, **options)
+        return super if options[:cache] == false
         if write_to_cache? || cache.has_key?(locale)
           cache[locale]
         else

diff --git a/spec/mobility/backend/cache_spec.rb b/spec/mobility/backend/cache_spec.rb
@@ -26,6 +26,12 @@ def backend_double
       2.times { expect(backend.read(:fr, options)).to eq("foo") }
     end
 
+    it "does not cache reads with cache: false option" do
+      backend = cached_backend_class.new("model", "attribute")
+      expect(backend.backend_double).to receive(:read).twice.with(:fr, options.merge(cache: false)).and_return("foo")
+      2.times { expect(backend.read(:fr, options.merge(cache: false))).to eq("foo") }
+    end
+
     it "always returns from cache if backend defines write_to_cache? to return true" do
       cache = double("cache")
       backend_class.class_eval do