Support added AR::Dirty methods #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shioyama
force-pushed
the
saved_changes
branch
2 times, most recently
from
0903aaf to
98d7260
Compare
shioyama
force-pushed
the
saved_changes
branch
from
6260bd1 to
14a75a0
Compare
shioyama
changed the title
shioyama
force-pushed
the
saved_changes
branch
from
14a75a0 to
1672b55
Compare
|
@brianstorti Here's a PR which adds Have a try and see what you think. |
shioyama
force-pushed
the
saved_changes
branch
from
1672b55 to
fc9b581
Compare
shioyama
force-pushed
the
saved_changes
branch
from
fc9b581 to
7b9c631
Compare
|
So good news is that the changes in AR 5.2 don't seem to be related to the added methods here. Bad news is that I haven't got a good solution for them yet... but I'll merge this PR later today since it seems to work fine, and I don't think it will add any issues to fixing the 5.2 issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #106