Disable AR::Dirty method overrides for AR >= 5.2 #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is no longer needed since attribute_will_change! is no longer overridden by AR::Dirty.
shioyama
force-pushed
the
disable_dirty_method_overrides
branch
from
0459d04 to
8aebadb
Compare
shioyama
commented
Nov 30, 2017
| end | ||
| model_class.extend has_attribute |
There was a problem hiding this comment.
For the first time in a long while I'm actually pleasantly surprised at changes in Rails. All this nasty stuff here we will be able to remove once we deprecate support for AR 5.1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These AM::Dirty methods are no longer overridden in AR::Dirty 5.2, so we don't need the overrides anymore.