Fix Sequel 5 issues #121
Merged
Fix Sequel 5 issues #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shioyama
force-pushed
the
fix_sequel_5_issues
branch
2 times, most recently
from
188e18a to
95a41dc
Compare
|
So the good news is, Sequel 5 is mostly working fine. The only thing that is failing is query support for the Table backend, because there is code which sets an instance variable on a dataset, and this is no longer possible since datasets in Sequel are now frozen by default and cannot be unfrozen by simply duping them, because The problem in Mobility is here, where we set an instance variable to avoid joining the same table more than once. This is admittedly not very nice code, but it serves an important purpose... |
shioyama
force-pushed
the
fix_sequel_5_issues
branch
from
95a41dc to
ce77fbd
Compare
|
Travis was being stupid about a couple builds, which seemed to be stuck, so I just merged this. It's passing anyway. Full support for Sequel 5.0 - yay! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #94