Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use module builder instance to define shared methods in closure #130

Merged
merged 10 commits into from
Dec 9, 2017

Conversation

shioyama
Copy link
Owner

@shioyama shioyama commented Dec 6, 2017

I had this ugly @attributes_extractor lambda that was passed into dynamically defined methods through a closure, but it's much simpler and more flexible to just define q = self and then define methods on the module builder itself. This will allow us to refactor out other shared functionality into methods on the module builder.

@shioyama shioyama force-pushed the refactor_attributes_extractor branch 6 times, most recently from 2abcbf1 to 6ccafcf Compare December 8, 2017 07:25
@shioyama shioyama force-pushed the refactor_attributes_extractor branch from 6ccafcf to 4a92980 Compare December 9, 2017 05:29
@shioyama shioyama merged commit 4a92980 into master Dec 9, 2017
@shioyama shioyama deleted the refactor_attributes_extractor branch December 12, 2017 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant