Rename default_fallbacks configuration to new_fallbacks / fallbacks_generator= #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is not enough on its own, but at least it should be clearer that the thing being set is not the fallbacks themselves. Once this has been released in 0.4 we can make a further change to clean this up for 1.0. |
shioyama
force-pushed
the
default_fallbacks_instance
branch
from
4593613 to
ee913ee
Compare
shioyama
force-pushed
the
default_fallbacks_instance
branch
from
1c4f3d3 to
cba295d
Compare
shioyama
changed the title
|
Note to self: Need to think some more about the naming and implementation of this configuration setting. The reader and writer methods do different things (reader returns an instance, writer sets a proc) which is confusing. |
shioyama
force-pushed
the
default_fallbacks_instance
branch
2 times, most recently
from
751a2c0 to
c686e32
Compare
shioyama
changed the title
shioyama
force-pushed
the
default_fallbacks_instance
branch
from
521bd9b to
5c1d895
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #81 and this SO question.