Refactor find_by for translated attributes #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shioyama
force-pushed
the
refactor_query_method_find_by
branch
from
7fe5a2d to
3b3e822
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #159, I changed how the jsonb and container backends query on translated attributes, but I noticed that this wasn't applying to some
first_by_<x>-type queries in Sequel. The reason is that some code had not been updated to the new format, but I realized it's much easier to just refactor all thisfirst_by_<x>(Sequel) +find_by_<x>(AR) method code to define these methods once, basically as an alias independent of the backend query details.This improves consistency and also chops off about 50 lines of code 😄