Improve initializer #186
Merged
Improve initializer #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shioyama
force-pushed
the
default_initializer
branch
from
5e90d28 to
669b472
Compare
It's more confusing than anything to have a bunch of stuff in default options that actually has no impact on anything. The only defaults in default_options that matter are cache and presence, which are turned on by default; the other ones can be nil and nothing changes, so we can just leave them out. If someone genuinely wants to entirely disable a plugin globally, the way to do it is by removing it from the +plugins+ array.
shioyama
force-pushed
the
default_initializer
branch
from
4d19dfe to
25c2d13
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #185