Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicitly implement matches/has_locale methods everywhere #194

Merged
merged 2 commits into from
Mar 21, 2018
Merged

Explicitly implement matches/has_locale methods everywhere #194

merged 2 commits into from
Mar 21, 2018

Conversation

shioyama
Copy link
Owner

No description provided.

shioyama added 2 commits March 21, 2018 23:19
@shioyama
De-duplicate has_locale in Backends::AR::PgQueryMethods
5733c9a 
This is more consistent with how it is done in Sequel.
@shioyama
Make matches/has_locale public
c88babc 
Since they're being overridden in subclasses, they should really be
public.
@shioyama shioyama merged commit c88babc into master Mar 21, 2018
@shioyama shioyama deleted the pg_query_methods_has_locale branch March 21, 2018 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@shioyama