Enforce null: false constraint on columns consistently #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shioyama
force-pushed
the
enforce_null_false_columns
branch
3 times, most recently
from
230c0e7 to
724462e
Compare
shioyama
force-pushed
the
enforce_null_false_columns
branch
from
724462e to
333db3d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed there were warnings in the Rails 4.2 specs because
null: falseis not specified ontimestampsin migrations. While fixing that, I've also enforced this constraint on KeyValue migrations for all columns other thanvalue, which I think is a better default.This will be released in 0.6.0 (should be the last release before 1.0).