Support equality predicates between jsonb nodes #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than handle equality in the PostgreSQL visitor, it's easier to do it in the node itself. This allows us to support a.eq(b) where both a and b are jsonb nodes, which previously would raise a stack error exception when Mobility attempted to convert b to JSON.
shioyama
commented
May 30, 2018
lib/mobility/arel/nodes/pg_ops.rb
Outdated
| when NilClass | ||
| to_question.not | ||
| when Integer, Array, Hash | ||
| to_dash_arrow.eq(other.to_json) |
There was a problem hiding this comment.
Previously Jsonb used the default -> operator, but this is problematic in general, so instead we now use ->> which returns a string and does not require casting. In case we are calling eq with an argument that is an integer, array or hash, we convert the argument to json and compare using -> as before.
Non-string translations are an edge case, but one that I want to support.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously it was not possible to create equality predicates between jsonb nodes. This fixes the issue, so you can do:
... and Mobility will return all posts whose
titleandcontentare the same, for Jsonb (and Container) backends (already worked for other backends). I think this is the last issue to fix before releasing 0.7.0 🎉