Default to OUTER JOIN for Table, KeyValue backends #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shioyama
force-pushed
the
join_translations_default_outer_join
branch
from
61ffe94 to
20fd538
Compare
shioyama
force-pushed
the
join_translations_default_outer_join
branch
from
20fd538 to
88bd59d
Compare
shioyama
added a commit
that referenced
this pull request
Sep 20, 2018
Same as #277 for ActiveRecord.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we default to an INNER join for the Table and KeyValue backends, although this never has any impact when using
wheresince we always have equality predicates which don't fall through to the default. But fororder, we currently use INNER join, which means that:will only return posts that have a non-NULL
titlecolumn. This seems counter-intuitive to me, so I'm changing the behaviour to use an OUTER join here so that all posts will be returned, even if they do not have a translation (in this casetitlewill be ordered as if it wasnil).I also found a small bug where
&&was returningfalseinstead ofnil, fixed here.