Fix deprecation in has_many associations #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks very much for this! I noticed some specs are failing not related to your changes here. Once #34 passes I'll merge that and you can rebase, and specs should pass. |
|
Ok #34 has been merged, can you rebase this? 😄 |
shioyama
reviewed
May 24, 2017
| @@ -78,7 +78,7 @@ def self.configure(options) | |||
|
|
|||
| has_many association_name, ->{ where key: association_attributes }, | |||
| as: :translatable, | |||
| class_name: translations_class, | |||
| class_name: "#{translations_class}", | |||
There was a problem hiding this comment.
Could this just be translations_class.to_s?
There was a problem hiding this comment.
If you prefer it that way I will change it.
Passing a class to the `class_name` is deprecated and will raise an ArgumentError in Rails 5.2
|
Ok I've started running tests against Rails 5.1 in the active_record_5.x branch, and as expected there are a few issues, many deprecation warnings and some failing specs. I'd like to handle these together, let me have a look and get back to this. |
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEPRECATION WARNING: Passing a class to the class_name is deprecated and will raise an ArgumentError in Rails 5.2. It eagerloads more classes than necessary and potentially creates circular dependencies. Please pass the class name as a string: has_many :mobility_text_translations, class_name: 'Mobility::ActiveRecord::TextTranslation'