Ensure that public/private scope of changes_applied, etc do not change #353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we were looking at the Active*Model* methods to se if they were private or public, and defining overrides accordingly. However, in some versions of Rails, the methods can be private in one module, but public in the other... so we need to ensure that the code actually looks at the correct +dirty_class+ to determine if the methods should be public or private.
|
Merged in ad9c66d, accidentally cherry-picked it so this wasn't automatically merged/closed. I'll just close it now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we were looking at the ActiveModel methods to se if they were private or public, and defining overrides accordingly. However, in some versions of Rails, the methods can be private in one module, but public in the other... so we need to ensure that the code actually looks at the correct +dirty_class+ to determine if the methods should be
public or private.
I never thought this dirty fix would be so complex...