Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ArgumentError: Call `select' with at least one field #359

Merged
merged 1 commit into from
May 12, 2020
Merged

ArgumentError: Call `select' with at least one field #359

merged 1 commit into from
May 12, 2020

Conversation

dlcmh
Copy link
Contributor

@dlcmh dlcmh commented Jan 22, 2020

@dlcmh dlcmh requested a review from shioyama January 22, 2020 08:31
@thealiilman thealiilman mentioned this pull request Apr 20, 2020
Closed
@shioyama
Copy link
Owner

Hello 👋 Thanks for the PR! Sorry for taking a long time to respond 😅

Could you rebase on master? I think tests should then pass (or at least not error out). Thanks!

@thealiilman
Copy link
Contributor

Hello 👋 Thanks for the PR! Sorry for taking a long time to respond 😅

Could you rebase on master? I think tests should then pass (or at least not error out). Thanks!

Hey Chris, I’ve rebased the PR. Tests are passing. 🙌 @shioyama

@shioyama
Copy link
Owner

shioyama commented May 8, 2020

Thanks very much! I'll merge and patch to the 0.8.x branch as well when I'm back home, and release a new version with the fix.

@shioyama
Copy link
Owner

shioyama commented May 8, 2020

Actually, can you add a test for it? So we don't break it in the future.

@thealiilman
Copy link
Contributor

Actually, can you add a test for it? So we don't break it in the future.

Sure, I'll add a test for it. 👍

@thealiilman
Copy link
Contributor

@shioyama A test has been written. 🤓

@shioyama
Copy link
Owner

Great, thanks! I'll merge and release later today.

@thealiilman
Copy link
Contributor

Great, thanks! I'll merge and release later today.

Thanks @shioyama for the review and for the great gem! 🙂

@shioyama shioyama merged commit 37d0934 into shioyama:master May 12, 2020
@shioyama
Copy link
Owner

This was released in 0.8.11 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shioyama shioyama shioyama approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dlcmh @shioyama @thealiilman