Refactor fallbacks plugin #433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shioyama
commented
Aug 23, 2020
| # instance. By default this is a proc which takes fallbacks and returns an | ||
| # instance of +I18n::Locale::Fallbacks+. | ||
| # @param [Proc] fallbacks generator | ||
| attr_writer :fallbacks_generator |
There was a problem hiding this comment.
I'm removing this, I doubt it's almost ever used and it's cluttering multiple unrelated parts of the codebase. Stuff like this will be configurable by overriding plugin methods on the Mobility::Attributes subclass. I've added a spec showing how to do this. Once I finish removing Configuration, this wil be easier to do directly from Mobility.configure.
shioyama
commented
Aug 23, 2020
| fallbacks_class.new(fallbacks) | ||
| end | ||
|
|
||
| class I18nFallbacks < ::I18n::Locale::Fallbacks |
There was a problem hiding this comment.
Thinking maybe this should be its own plugin....
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fallbacks plugin is a total mess. For now, I'm just going to rip out the parts of it that pollute other namespaces, while leaving the existing usage intact. In another PR I'll update the usage once I've gone through the suite to fix hidden dependencies (a lot of specs actually fail if you remove fallbacks right now because they depend on it being their implicitly.)