Remove Configuration#accessor_method #450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shioyama
force-pushed
the
remove_accessor_method
branch
from
61fa5f2 to
ba908c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simply aliases
accessor_methodtotranslates, allowing you to name it something else. Sincetranslatesis now very very easy to define yourself, I think this is unnecessary. If you want to give it a different name, you can just define the same macro with a different name.Also removing
mobility_accessor,mobility_readerandmobility_writer, since now thatreaderandwriterare just plugins, it's very easy to enable/disable them by passingreader: falseorwriter: falseto `translates. No special treatment required.