Remove Mobility::Backend#apply_plugin #454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We know the dependencies are satisfied since the backend plugin only has one: attributes, and it's declared with "include: before".
The name +apply_plugin+ falsely indicates that this is a generic method, when in fact it has a very specific use case in the cache plugin. Let's remove it and just make this explicit, so now the cache plugin looks for a method on the backend, which if present will be called, otherwise defaults to simple cache implementation. This is not beautiful but I think better since it reduces clutter and complexity in the base Mobility::Backend module.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method should not exist; it's only there for backends to hook into the cache plugin. Let's see if we can get rid of it.