Correctly override default backend options #495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After thinking this over for a bit, I think I'm going to use this as an opportunity to cleanly separate "backend options" from "plugin options". We'll still support passing them together in the options hash to |
|
Ok for now I think this will do. If this passes I'll merge later and release in 1.0.4. |
shioyama
force-pushed
the
backend_options_different_backends
branch
3 times, most recently
from
2e9e04e to
452be8f
Compare
shioyama
force-pushed
the
backend_options_different_backends
branch
from
452be8f to
d35fc0f
Compare
shioyama
force-pushed
the
backend_options_different_backends
branch
from
9b5f43b to
d9bceeb
Compare
|
Released as 1.0.4. @kevynlebouille can you check the new version works? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #492
This is not a super clean fix, but tests check that it's doing what one would expect.
cc @kevynlebouille