Fix Sequel querying on untranslated attributes in i18n block
#529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shioyama
changed the title
18n block
shioyama
changed the title
18n blocki18n block
This code is not actually covered by tests, but Sequel::SQL::Expression does not have `args`, ComplexExpression does, so let's fix this.
shioyama
force-pushed
the
fix_sequel_querying
branch
from
dbcffe2 to
72959de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed this wasn't working correctly while working on another PR.
Once tests pass I'l ship this as 1.1.4.I'll ship this in 1.2.