Refactor options handling in backend accessors #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shioyama
force-pushed
the
refactor_options
branch
4 times, most recently
from
8bbfbaa to
7eeb432
Compare
shioyama
force-pushed
the
refactor_options
branch
2 times, most recently
from
ee43b1b to
f054450
Compare
Rule of thumb: create a new options hash if the hash will be modified, otherwise use the hash passed in. The **options form will automatically create a new hash, which may or may not be what is needed depending on the context.
shioyama
force-pushed
the
refactor_options
branch
from
f054450 to
c39414d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge after #62