-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix current Rubocop Issues #111
Conversation
This pull request has been linked to Shortcut Story #10366: Billwerk gem: Fehlende #frozen_string_literal Kommentare hinzufügen. |
08b659b
to
4b8e4c1
Compare
9f99ba8
to
7086c55
Compare
7086c55
to
15179f3
Compare
LooksGoodToMe |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like having Rubocop as an extra step in the CI 👍
.circleci/config.yml
Outdated
name: Install ruby dependencies | ||
command: gem update --system; bin/setup | ||
- run: | ||
name: Execute specs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about a more descriptive name? Something like Run Rubocop
maybe?
Code Climate has analyzed commit 800c758 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 76.9% (50% is the threshold). This pull request will bring the total coverage in the repository to 90.1% (0.5% change). View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RTM 👍
Should also fix the following Stories:
SC-10366