Fix current Rubocop Issues #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #10366: Billwerk gem: Fehlende #frozen_string_literal Kommentare hinzufügen. |
mortik
force-pushed
the
chore/rubocop
branch
from
08b659b
to
4b8e4c1
Compare
added 5 commits
February 17, 2022 17:49
mortik
force-pushed
the
chore/rubocop
branch
2 times, most recently
from
9f99ba8
to
7086c55
Compare
mortik
force-pushed
the
chore/rubocop
branch
from
7086c55
to
15179f3
Compare
|
LooksGoodToMe |
SteffenHam
requested changes
Apr 21, 2022
.circleci/config.yml
Outdated
| name: Install ruby dependencies | ||
| command: gem update --system; bin/setup | ||
| - run: | ||
| name: Execute specs |
There was a problem hiding this comment.
How about a more descriptive name? Something like Run Rubocop maybe?
mortik
commented
Apr 21, 2022
|
Code Climate has analyzed commit 800c758 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 76.9% (50% is the threshold). This pull request will bring the total coverage in the repository to 90.1% (0.5% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should also fix the following Stories:
SC-10366