-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Download Invoices as PDF #60
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some files could not be reviewed due to errors:
.rubocop.yml: Lint/ConditionPosition has the wrong namespace - should be Layout
.rubocop.yml: Lint/ConditionPosition has the wrong namespace - should be Layout Error: The `Style/TrailingCommaInLiteral` cop no longer exists. Please use `Style/TrailingCommaInArrayLiteral` and/or `Style/TrailingCommaInHashLiteral` instead. (obsolete configuration found in .rubocop.yml, please update it)
Add the ``invoice_download`` method to allow downloading an invoice's PDF document. The method returns, as does the API call, the PDF in plain text as a ``String``. Billwerk Documentation: https://developer.billwerk.io/Docs/ApiReference#/Invoices/Invoices_GetDirectDownload
3dc0feb
to
b552d44
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some files could not be reviewed due to errors:
.rubocop.yml: Lint/ConditionPosition has the wrong namespace - should be Layout
.rubocop.yml: Lint/ConditionPosition has the wrong namespace - should be Layout Error: The `Style/TrailingCommaInLiteral` cop no longer exists. Please use `Style/TrailingCommaInArrayLiteral` and/or `Style/TrailingCommaInHashLiteral` instead. (obsolete configuration found in .rubocop.yml, please update it)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unseren aktuellen Code Styles folgt es leider nicht so, aber Konsistenz ist da denke ich sinnvoller, warum auch immer in den specs Instanzmethoden mit .
described werden?
Trotzdem eine Rückfrage zu den specs.
@@ -84,4 +84,32 @@ | |||
expect(request).to have_been_made | |||
end | |||
end | |||
|
|||
describe '.invoice_download' do | |||
it "requests the correct resource" do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ich finde da die beiden specs exakt das selbe tun könnte das auch gerne einer sein, was meinst du? Wenn man kein and
möchte vielleicht returns the pdf as a string after requesting the correct resource
(das es eine PDF ist finde ich hier btw so oder so noch interessant zur Dokumentation, auch wenn man das wohl schwer testen kann).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some files could not be reviewed due to errors:
.rubocop.yml: Lint/ConditionPosition has the wrong namespace - should be Layout
.rubocop.yml: Lint/ConditionPosition has the wrong namespace - should be Layout Error: The `Style/TrailingCommaInLiteral` cop no longer exists. Please use `Style/TrailingCommaInArrayLiteral` and/or `Style/TrailingCommaInHashLiteral` instead. (obsolete configuration found in .rubocop.yml, please update it)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ready to merge 👍
Add the
invoice_download
method to allow downloading an invoice'sPDF document. The method returns, as does the API call, the PDF in plain
text as a
String
.Billwerk Documentation: https://developer.billwerk.io/Docs/ApiReference#/Invoices/Invoices_GetDirectDownload