Download Invoices as PDF #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Apr 16, 2019
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
.rubocop.yml: Lint/ConditionPosition has the wrong namespace - should be Layout
.rubocop.yml: Lint/ConditionPosition has the wrong namespace - should be Layout Error: The `Style/TrailingCommaInLiteral` cop no longer exists. Please use `Style/TrailingCommaInArrayLiteral` and/or `Style/TrailingCommaInHashLiteral` instead. (obsolete configuration found in .rubocop.yml, please update it)
Add the ``invoice_download`` method to allow downloading an invoice's PDF document. The method returns, as does the API call, the PDF in plain text as a ``String``. Billwerk Documentation: https://developer.billwerk.io/Docs/ApiReference#/Invoices/Invoices_GetDirectDownload
3wille
force-pushed
the
fw-invoice-pdf-download
branch
from
3dc0feb
to
b552d44
Compare
houndci-bot
reviewed
Apr 16, 2019
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
.rubocop.yml: Lint/ConditionPosition has the wrong namespace - should be Layout
.rubocop.yml: Lint/ConditionPosition has the wrong namespace - should be Layout Error: The `Style/TrailingCommaInLiteral` cop no longer exists. Please use `Style/TrailingCommaInArrayLiteral` and/or `Style/TrailingCommaInHashLiteral` instead. (obsolete configuration found in .rubocop.yml, please update it)
kaipr
requested changes
Apr 23, 2019
| @@ -84,4 +84,32 @@ | |||
| expect(request).to have_been_made | |||
| end | |||
| end | |||
|
|
|||
| describe '.invoice_download' do | |||
| it "requests the correct resource" do | |||
There was a problem hiding this comment.
Ich finde da die beiden specs exakt das selbe tun könnte das auch gerne einer sein, was meinst du? Wenn man kein and möchte vielleicht returns the pdf as a string after requesting the correct resource (das es eine PDF ist finde ich hier btw so oder so noch interessant zur Dokumentation, auch wenn man das wohl schwer testen kann).
houndci-bot
reviewed
Apr 23, 2019
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
.rubocop.yml: Lint/ConditionPosition has the wrong namespace - should be Layout
.rubocop.yml: Lint/ConditionPosition has the wrong namespace - should be Layout Error: The `Style/TrailingCommaInLiteral` cop no longer exists. Please use `Style/TrailingCommaInArrayLiteral` and/or `Style/TrailingCommaInHashLiteral` instead. (obsolete configuration found in .rubocop.yml, please update it)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the
invoice_downloadmethod to allow downloading an invoice'sPDF document. The method returns, as does the API call, the PDF in plain
text as a
String.Billwerk Documentation: https://developer.billwerk.io/Docs/ApiReference#/Invoices/Invoices_GetDirectDownload