Update faraday_middleware #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* set `faraday_middleware` version to be `>= 1.0.0` * amend `PactasItero::Response::RaiseError` to conform with the [guides for custom faraday middlewares](https://lostisland.github.io/faraday/middleware/custom) [ch6713](https://app.clubhouse.io/shipcloud/story/6713)
|
This pull request has been linked to Clubhouse Story #6713: Update faraday und faraday_middleware. |
malachewhiz
reviewed
Feb 17, 2021
Comment on lines
11
to
12
|
|
||
| private | ||
|
|
||
| def on_complete(response) | ||
| if error = PactasItero::Error.from_response(response) | ||
| raise error | ||
| def call(request_env) |
There was a problem hiding this comment.
Die Leerzeile kann noch weg.
In dem verlinkten Guide steht unten:
Do I need to override #call?
For the majority of middleware, it’s not necessary to override the #call method. You can instead use #on_request and #on_complete.
weswegen auch #on_complete nach wie vor praktikabel wäre. Bei der Variante mit #call steht noch:
When you do so, remember to call either app.call(env) or super to avoid breaking the middleware stack call!
Da du das tust, ist diese Variante aber so auch ok.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
faraday_middlewareversion to be>= 1.0.0PactasItero::Response::RaiseErrorto conform with theguides for custom faraday middlewares
ch6713