Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: parse pcks8 private key issue #34

Merged
merged 1 commit into from
Aug 26, 2023
Merged

fix: parse pcks8 private key issue #34

merged 1 commit into from
Aug 26, 2023

Conversation

shipengqi
Copy link
Owner

@shipengqi shipengqi commented Aug 26, 2023

Thank you for contributing to golib!

Please add a summary of your change

fix parse pcks8 private key issue

Does your change fix a particular issue?

Fixes #(issue)

#33

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

@codecov-commenter
Copy link

Codecov Report

Merging #34 (7a9f6cb) into main (dc19c24) will increase coverage by 0.14%.
The diff coverage is 58.33%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main      #34      +/-   ##
==========================================
+ Coverage   71.50%   71.65%   +0.14%     
==========================================
  Files          22       22              
  Lines         958      963       +5     
==========================================
+ Hits          685      690       +5     
  Misses        198      198              
  Partials       75       75              
Flag Coverage Δ
unittests 71.65% <58.33%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
crtutil/key.go 48.00% <0.00%> (ø)
fsutil/tar.go 51.61% <ø> (ø)
sysutil/sys_unix.go 75.00% <ø> (ø)
strutil/str.go 100.00% <100.00%> (ø)
sysutil/sys.go 78.00% <100.00%> (+2.44%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@shipengqi shipengqi merged commit a3c204a into main Aug 26, 2023
12 checks passed
@shipengqi shipengqi deleted the fix/pkcs8-error branch August 26, 2023 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants