Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove encoder options #20

Merged
merged 7 commits into from
Sep 6, 2023
Merged

Conversation

shipengqi
Copy link
Owner

Thank you for contributing to log!

Please add a summary of your change

feat: remove encoder options

Does your change fix a particular issue?

Fixes #(issue)

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

@codecov-commenter
Copy link

Codecov Report

Merging #20 (1d911a5) into main (5d1acb7) will decrease coverage by 1.59%.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main      #20      +/-   ##
==========================================
- Coverage   60.24%   58.65%   -1.59%     
==========================================
  Files           4        4              
  Lines         410      387      -23     
==========================================
- Hits          247      227      -20     
+ Misses        159      156       -3     
  Partials        4        4              
Flag Coverage Δ
unittests 58.65% <100.00%> (-1.59%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
encoder.go 89.47% <ø> (-5.13%) ⬇️
options.go 40.00% <ø> (+3.75%) ⬆️
log.go 61.11% <100.00%> (ø)
logger.go 62.03% <100.00%> (-0.86%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@shipengqi shipengqi merged commit 6283da1 into main Sep 6, 2023
12 checks passed
@shipengqi shipengqi deleted the feat/remove-encoder-options branch September 6, 2023 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants