feat: use biome instead of eslint for linting

[LucasB25]

• Remove eslint
• Add biome
• Update packages

Fixed the concerns that lint detected

npm run lint

[Deivu]

We recently moved our configs to a dedicated repo which is here https://github.com/shipgirlproject/eslint-config.

Do biome support this configuration? We are transitioning to a global lint settings

[LucasB25]

You have to look at the biome site to get the best configuration for the code but yes it is extremely complete

[Deivu]

Putting this on hold for the meantime as I'm doing other things, This may get rejected since we are gonna favor global configs, but we'll see

[LucasB25]

Eslint and bad, biome allows to have a code much cleaner knowing that it signals you the code errors and there are quite a lot of them currently

[0t4u]

No. Eslint has a mature ecosystem of plugins and rules, and last time I checked biome is not production ready. Eslint speed is "good enough" for a relatively small project such as shoukaku, and just does not make sense for us.

[0t4u]

Eslint and bad, biome allows to have a code much cleaner knowing that it signals you the code errors and there are quite a lot of them currently

Your point makes no sense because what you're describing is just a linter, which both eslint and biome are.

Why is eslint bad?

[EvilG-MC]

The only reason for this is: "I don't like ESLint and I don't want them to use it either." I find it a bit... Strange, let's leave it at that, wanting to change something that in this case, these guys seem to work properly and without problems.

I don't use ESLint but if it works for them, great.

The only thing I can add is to add a pre-commit to format the code in the commits. Maybe I'll do a PR for it.

[0t4u]

The only reason for this is: "I don't like ESLint and I don't want them to use it either." I find it a bit... Strange, let's leave it at that, wanting to change something that in this case, these guys seem to work properly and without problems.

I don't use ESLint but if it works for them, great.

The only thing I can add is to add a pre-commit to format the code in the commits. Maybe I'll do a PR for it.

Code style is already enforced by CI and you need those to pass to merge PRs anyways. It should be fine as is.

[Deivu]

The only reason for this is: "I don't like ESLint and I don't want them to use it either." I find it a bit... Strange, let's leave it at that, wanting to change something that in this case, these guys seem to work properly and without problems.
I don't use ESLint but if it works for them, great.
The only thing I can add is to add a pre-commit to format the code in the commits. Maybe I'll do a PR for it.

Code style is already enforced by CI and you need those to pass to merge PRs anyways. It should be fine as is.

The thing is, eslint fails to enforce tabs and indents

[0t4u]

The only reason for this is: "I don't like ESLint and I don't want them to use it either." I find it a bit... Strange, let's leave it at that, wanting to change something that in this case, these guys seem to work properly and without problems.

I don't use ESLint but if it works for them, great.

The only thing I can add is to add a pre-commit to format the code in the commits. Maybe I'll do a PR for it.

Code style is already enforced by CI and you need those to pass to merge PRs anyways. It should be fine as is.

The thing is, eslint fails to enforce tabs and indents

It is in the rules, and tbh we should probably use prettier for that purpose.

[EvilG-MC]

I see, thanks for the explanation I appreciate it.

[LucasB25]

The only reason for this is: "I don't like ESLint and I don't want them to use it either." I find it a bit... Strange, let's leave it at that, wanting to change something that in this case, these guys seem to work properly and without problems.

I don't use ESLint but if it works for them, great.

The only thing I can add is to add a pre-commit to format the code in the commits. Maybe I'll do a PR for it.

Since the latest version of ESLint, many plugins no longer work, causing issues that force you to stick with the previous version. Personally, I don't mind, but Biome is much more efficient in every aspect, far less tedious to configure, and it catches a lot more errors and inconsistencies in the code.

do a simple 'npm run lint' and you will see that there are problems in the logic of the code that eslint would not have provided