Access git info via ValueSource for Gradle Configuration Cache Compatibility #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM but please update version in https://github.com/shipkit/shipkit-auto-version/blob/master/version.properties#L3 to |
|
@koral-- i've updated the version |
koral--
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the way that
gitinfo is accessed. It does so in a way recommended by Gradle so that projects that use this plugin can take advantage of Gradle's configuration cache. This doc from Gradle explains the API that's being used here.One additional change is that the version of Gradle was updated to the latest. This is because the changes include Gradle APIs that were experimental in Gradle 7, but are stable in 8.