Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update workflow configuration #63

Merged
merged 2 commits into from
Dec 29, 2020
Merged

Update workflow configuration #63

merged 2 commits into from
Dec 29, 2020

Conversation

shestee
Copy link
Contributor

@shestee shestee commented Dec 29, 2020

  1. Removing '--scan' argument from ci.yml workflow file and moving the control of scan publishing to settings.gradle makes configuration simpler to set.
  2. Recently new 'githubToken' property was added to Shipkit Changelog plugin. This property is used to authenticate in Github Api, both to fetch and write, instead of 'readOnlyToken' and 'writeToken'. We should replace deprecated properties with the new one.

@shestee
Refactored scan publishing settings
248e7c3 
Removed unnecessary '--scan' argument from ci.yml workflow file. Now control of scan publishing is moved to settings.gradle file and scan is set to be published only if build is run in CI. This change uses Gradle's Enterprise 'publishAlways()' which depends here on getting "CI" env var from CI and makes configuration simpler to set.
@shestee
Apply 'githubToken' property
f747af1 
Start using new Shipkit Changelog's 'githubToken' property to authenticate in GitHub Api, both to fetch and write, instead of deprecated  'readOnlyToken' and 'writeToken' properties.
mockitoguy
mockitoguy approved these changes Dec 29, 2020
View reviewed changes
Copy link
Contributor

@mockitoguy mockitoguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@mockitoguy mockitoguy merged commit 9b6fe7a into shipkit:master Dec 29, 2020
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mockitoguy mockitoguy mockitoguy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shestee @mockitoguy