Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configurable tag convention #69

Merged
merged 1 commit into from
Mar 21, 2021
Merged

Configurable tag convention #69

merged 1 commit into from
Mar 21, 2021

Conversation

mockitoguy
Copy link
Contributor

@mockitoguy mockitoguy commented Mar 20, 2021 •
edited
Loading

Fixes #8

Tested by:

  • new and existing tests
  • manual run in "mockito-kotlin" and "shipkit-changelog"

@mockitoguy mockitoguy requested a review from shestee March 20, 2021 18:07
@mockitoguy
Copy link
Contributor Author

@shestee, do you want to take a stab at reviewing this? Please merge if looks good.

@mockitoguy mockitoguy mentioned this pull request Mar 21, 2021
Merged
@shestee
Copy link
Contributor

shestee commented Mar 21, 2021

It looks great! Thanks

@shestee shestee merged commit a906597 into master Mar 21, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shestee shestee Awaiting requested review from shestee

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support different release tag naming conventions
2 participants
@mockitoguy @shestee