Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New & Better Docker Image #29

Merged
merged 11 commits into from
Feb 7, 2024
Merged

New & Better Docker Image #29

merged 11 commits into from
Feb 7, 2024

Conversation

sethsandaru
Copy link
Member

@sethsandaru sethsandaru commented Feb 6, 2024

The goal of the new image:

  • You can define ENV on the fly (docker ... or docker-compose.yml)
  • You don't have to manually run the migration (for new updates), pull out the new image and start it
  • Suitable for both production & development
    • Production: you set your desired configurations (Database, S3,...
    • Development: only hit the docker run and you got it all (sqlite as default)

😎

Additionally, added a GH action to test the Docker build of both images, to ensure PR changes are buildable

Testing via: GH Codespace

Copy link

codecov bot commented Feb 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (94d0efa) 98.05% compared to head (d739888) 98.05%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main      #29   +/-   ##
=========================================
  Coverage     98.05%   98.05%           
  Complexity      178      178           
=========================================
  Files            63       63           
  Lines           872      872           
=========================================
  Hits            855      855           
  Misses           17       17           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sethsandaru sethsandaru merged commit 76d7950 into main Feb 7, 2024
6 checks passed
@sethsandaru sethsandaru deleted the new-image branch February 7, 2024 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant