This repository has been archived by the owner on Oct 9, 2024. It is now read-only.
Allow ember-prism to be used by other addons #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ping @brandonjmckay – anything I can do to help clarify on this? |
|
Cool, thanks. Just got back from vacation. I'll try to check this out this week. |
bj-mcduck
pushed a commit
that referenced
this pull request
Sep 4, 2015
Allow ember-prism to be used by other addons
|
👍 Thanks! |
|
@brandonjmckay Not urgent, but when you have a chance could you publish a new release to NPM to capture these changes? |
bj-mcduck
added a commit
that referenced
this pull request
Oct 14, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows addons to make use of
ember-prismin their own components (with a bit of elbow grease from the author). It contains small refactorings to expose two functions,installPrismBowerPackageandimportPrismSources, to allow consuming addons to pull Prism into their host applications. This follows a similar form-factor to the solution used by ember-tether.I pulled the definition of those two functions off of their owning objects to reinforce for the authors of any future changes that they're now "public", but can move them back inline if you'd prefer.
The change as a whole just amounted to some refactoring and documentation. Apps using
ember-prismtoday should see no difference.Note: one acceptance test (
Acceptance | CodeBlock: hasline-numbersplugin) is failing, but that also seems to be the case on master.