Add createModalOverlay function (#358)

Fixes #347
shipshapecode · Apr 22, 2019 · 5ec4c04 · 5ec4c04
1 parent 1635e64
commit 5ec4c04
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 12 deletions.
diff --git a/src/js/modal.js b/src/js/modal.js
@@ -11,16 +11,7 @@ import defer from 'lodash-es/defer';
 
 export class Modal {
   constructor(options) {
-    if (!this._modalOverlayElem) {
-      this._modalOverlayElem = createModalOverlay();
-      this._modalOverlayOpening = getModalMaskOpening(this._modalOverlayElem);
-
-      // don't show yet -- each step will control that
-      this.hide();
-
-      document.body.appendChild(this._modalOverlayElem);
-    }
-
+    this.createModalOverlay();
     this.options = options;
 
     return this;
@@ -42,6 +33,21 @@ export class Modal {
     });
   }
 
+  /**
+   * Create the modal overlay, if it does not already exist
+   */
+  createModalOverlay() {
+    if (!this._modalOverlayElem) {
+      this._modalOverlayElem = createModalOverlay();
+      this._modalOverlayOpening = getModalMaskOpening(this._modalOverlayElem);
+
+      // don't show yet -- each step will control that
+      this.hide();
+
+      document.body.appendChild(this._modalOverlayElem);
+    }
+  }
+
   /**
    * Hide the modal overlay
    */
@@ -102,4 +108,4 @@ export class Modal {
       closeModalOpening(this._modalOverlayOpening);
     }
   }
-}
+}
diff --git a/src/js/tour.js b/src/js/tour.js
@@ -80,6 +80,8 @@ export class Tour extends Evented {
       })(event);
     });
 
+    this.modal = new Modal(options);
+
     this._setTooltipDefaults();
     this._setTourID();
 
@@ -309,7 +311,7 @@ export class Tour extends Evented {
    * @private
    */
   _setupActiveTour() {
-    this.modal = new Modal(this.options);
+    this.modal.createModalOverlay();
     this._addBodyAttrs();
     this.trigger('active', { tour: this });