Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shift + tab on init breaks out of tour modal #1076

Closed
sitrobotsit opened this issue Aug 3, 2020 · 0 comments
Closed

shift + tab on init breaks out of tour modal #1076

sitrobotsit opened this issue Aug 3, 2020 · 0 comments
Labels
bug

Comments

@sitrobotsit
Copy link

Replication steps:

  1. Load tour
  2. Use the keyboard to select SHIIFT + TAB

Expected behaviour; focus should be contained within the tour box.
Actual behaviour; focus breaks out of tour box and to the last element on the page.

This behaviour is replaceable here https://shepherdjs.dev/
faizanu94 added a commit to faizanu94/shepherd that referenced this issue Aug 25, 2020
@faizanu94
fixes shipshapecode#1076
7390775
@faizanu94 faizanu94 mentioned this issue Aug 25, 2020
Merged
RobbieTheWagner pushed a commit that referenced this issue Aug 31, 2020
@faizanu94
shift + tab handled (#1119)
ebdd8fc 
* fixes #1076

* Update shepherd-element.svelte
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sitrobotsit @RobbieTheWagner