-
-
Notifications
You must be signed in to change notification settings - Fork 646
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shepherd.Tour constructor definition of steps errors with showOn being undefined #114
Comments
This is not a feature as far as I know. You should create steps using the |
This should be reopened as it is a feature in the docs:
|
I just tried this too as it is in the docs. Got the same error. |
+1 |
What it says in the docs is What it doesn't say in the docs is how to create a Step instance manually. The signature is My question is, how the actual fuck are we supposed to supply the Tour instance to Tour constructor? IDK if the chicken came before the egg but it definitely came before the chicken sandwich... |
@Pamblam I think you are supposed to create a new tour manually, then manually pass it to each manually created step. That being said, we should probably just rewrite |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
When trying to define Shepherd Tour via a steps property passed to the constructor I receive an error "cannot read property showOn of undefined". The steps are very primitive and work with the addStep method:
The text was updated successfully, but these errors were encountered: