Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove or restore hide method on Tour instance #249

Closed
chuckcarpenter opened this issue Sep 19, 2018 · 0 comments
Closed

Remove or restore hide method on Tour instance #249

chuckcarpenter opened this issue Sep 19, 2018 · 0 comments
Assignees
@BrianSipple
Labels
bug

Comments

@chuckcarpenter
Copy link
Member

The docs say that you can call hide() on the tour to hide the current step, but that method is only on the step itself, so with Shepherd.activeTour.getCurrentStep().hide() does work.

https://shipshapecode.github.io/shepherd/#tour-methods
@BrianSipple BrianSipple self-assigned this Oct 9, 2018
BrianSipple added a commit that referenced this issue Oct 9, 2018
@BrianSipple
Implement Tour.hide
ead2428 
Closes [#249](#249).
@BrianSipple BrianSipple mentioned this issue Oct 9, 2018
Merged
BrianSipple added a commit that referenced this issue Oct 9, 2018
@BrianSipple
Implement Tour.hide
413cc3a 
Closes [#249](#249).
BrianSipple added a commit that referenced this issue Oct 9, 2018
@BrianSipple
Implement Tour.hide
b9dc093 
Closes [#249](#249).
BrianSipple added a commit that referenced this issue Oct 9, 2018
@BrianSipple
Implement Tour.hide
09fff87 
Closes [#249](#249).
BrianSipple added a commit that referenced this issue Oct 9, 2018
@BrianSipple
Implement Tour.hide
e864184 
Closes [#249](#249).
BrianSipple added a commit that referenced this issue Oct 9, 2018
@BrianSipple
Implement Tour.hide
974f003 
Closes [#249](#249).
BrianSipple added a commit that referenced this issue Oct 10, 2018
@BrianSipple
Implement Tour.hide
3927ef2 
Closes [#249](#249).
BrianSipple added a commit that referenced this issue Oct 10, 2018
@BrianSipple
Implement Tour.hide
b11fba8 
Closes [#249](#249).
BrianSipple added a commit that referenced this issue Oct 10, 2018
@BrianSipple
Implement Tour.hide
94e9fd5 
Closes [#249](#249).
RobbieTheWagner pushed a commit that referenced this issue Oct 10, 2018
@BrianSipple @RobbieTheWagner
Implement Tour.hide (#265)
a821cd5 
Closes [#249](#249).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BrianSipple BrianSipple

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chuckcarpenter @BrianSipple