Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Popover position at (0, 0) when target is rerendered #580

Closed
VladimirAnaniev opened this issue Sep 26, 2019 · 4 comments · Fixed by #583
Closed

Popover position at (0, 0) when target is rerendered #580

VladimirAnaniev opened this issue Sep 26, 2019 · 4 comments · Fixed by #583
Labels
bug

Comments

@VladimirAnaniev
Copy link
Contributor

VladimirAnaniev commented Sep 26, 2019 •
edited
Loading

Seems like a duplicate of #112 though it is said there it should have been fixed.
Stackblitz with example: https://stackblitz.com/edit/shepherd-rerender-target?file=index.html
2019-09-26_18-15-07

Steps to reproduce

  1. Start tour.
  2. Destroy and rerender the target of one of the tour steps.
  3. Go to that step

Expected result

The newly created element is highlighted and popover is targeting it.

Actual result

Popover is positioned at (0, 0).
@RobbieTheWagner
Copy link
Member

@VladimirAnaniev a lot has changed since that previous issue. We've rewritten a lot of the logic. We probably need to add a check to see if the element set as the target initially still exists.

@VladimirAnaniev
Copy link
Contributor Author

Any idea when this might be fixed? Many of our steps have dynamic targets and we are hitting this issue for all of them.

@RobbieTheWagner
Copy link
Member

I will take a look today and see if I can find a workaround

RobbieTheWagner added a commit that referenced this issue Sep 27, 2019
@RobbieTheWagner
Recreate elements each time on show
4d8210a 
Fixes #580
@RobbieTheWagner RobbieTheWagner mentioned this issue Sep 27, 2019
Merged
@RobbieTheWagner
Copy link
Member

@VladimirAnaniev I opened a PR to fix this issue

chuckcarpenter pushed a commit that referenced this issue Sep 27, 2019
@RobbieTheWagner @chuckcarpenter
Recreate elements each time on show (#583)
0fff410 
* Recreate elements each time on show

Fixes #580

* Fix test timing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Recreate elements each time on show shipshapecode/shepherd
2 participants
@RobbieTheWagner @VladimirAnaniev